Is Optimism good for longevity?

Yes — the evidence for this is strong. Dispositional optimism has one of the more consistent bodies of prospective evidence linking a psychological trait to mortality. That's reflected in an evidence score of 80/100 for its role in longevity, drawn from 7 studies, with an estimated impact on longevity rated moderate (55/100).